Re: [Xen-devel] [PATCH v3 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

["Wang, Wei W" <wei.w.wang@xxxxxxxxx>]

On 11/06/2015 22:02, Julien Grall wrote:
> On 11/06/2015 04:31, Wei Wang wrote:
> > -    list_for_each(pos, &cpufreq_governor_list)
> > +    if (policy->policy)
> 
> What if another cpufreq decides to use policy->policy?

What is "another cpufreq"? The "policy" is per-CPU struct.

 > > +        gov_num = INTEL_PSTATE_INTERNAL_GOV_NUM;
> 
> Why not using cpufreq_governor_list?

That's used by the old driver. We are not going through that old governor layer.

> > +    else
> > +    {
> > +        list_for_each(pos, &cpufreq_governor_list)
> >           gov_num++;
> 
> The indentation looks wrong to me.

It has four "+$", should be correct.

Best,
Wei

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel