[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c



Hi,

On 11/06/2015 04:31, Wei Wang wrote:
-    list_for_each(pos, &cpufreq_governor_list)
+    if (policy->policy)

What if another cpufreq decides to use policy->policy?

+        gov_num = INTEL_PSTATE_INTERNAL_GOV_NUM;

Why not using cpufreq_governor_list?

+    else
+    {
+        list_for_each(pos, &cpufreq_governor_list)
          gov_num++;

The indentation looks wrong to me.

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.