Re: [Xen-devel] [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 06/11/2015 12:03 PM, Julien Grall wrote:
> 
> 
> On 11/06/2015 02:12, Olaf Hering wrote:
>> On Wed, Jun 10, Julien Grall wrote:
>>
>>> There is also a variable MAX_CPUS defined to 256. which is used every.
>>
>> You are right, while forwarding an old patch (from memory) I changed the
>> wrong place. MAX_CPUS is already at 256 so no change is strictly
>> neccessary.
>>
>> I suggest to drop that patch from this series while applying.
>> Thanks for the review.
> 
> I would suggest some refactoring to remove NR_CPUS and associated code
> in order to avoid mis-usage later.
> 
> Also, cpu_mask_t is a uint32_t, is it intentional?

When xenalyze was originally written back in 2006, I think that's
probably how it was defined in Xen.  I just haven't used it on a system
with more than 32 cpus. :-)

That certainly should be addressed at some point.  I'd be in favor of
checking this in and fixing it up later; or, for the time being, just
disabling the skew detection functionality (which is the only place that
uses it, AFAICT).

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel