Re: [Xen-devel] [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Olaf,

On 09/06/2015 07:23, Olaf Hering wrote:
> To match the hypervisor default which was introduced in
> 9da0c5b63933b9912e3903190601661813954d0d, bump the limit.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>   tools/xentrace/analyze.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xentrace/analyze.h b/tools/xentrace/analyze.h
> index 40ee551..64b1911 100644
> --- a/tools/xentrace/analyze.h
> +++ b/tools/xentrace/analyze.h
> @@ -16,7 +16,7 @@
>
>   #define TRC_LOST_RECORDS_END    (TRC_GEN + 50)
>
> -#define NR_CPUS 128
> +#define NR_CPUS 256
You are updating NR_CPUS but this is only used for cpumask_t which is 
never used within xenalyze.
Only cpu_mask_t is used and alias to a uint32_t. Or did I miss something?

There is also a variable MAX_CPUS defined to 256. which is used every.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel