Re: [Xen-devel] [PATCH v11 7/9] tools: Add vmware_port support

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 06/04/15 11:49, Ian Campbell wrote:
> On Wed, 2015-06-03 at 18:06 +0100, George Dunlap wrote:
>> On 05/22/2015 04:50 PM, Don Slutz wrote:
>>> This new libxl_domain_create_info field is used to set
>>> XEN_DOMCTL_CONFIG_VMWARE_PORT_MASK in the xc_domain_configuration_t
>>> for x86.
>>>
>>> In xen it is is_vmware_port_enabled.
>>>
>>> If is_vmware_port_enabled then
>>>   enable a limited support of VMware's hyper-call.
>>>
>>> VMware's hyper-call is also known as VMware Backdoor I/O Port.
>>>
>>> if vmware_port is not specified in the config file, let
>>> "vmware_hwver != 0" be the default value.  This means that only
>>> vmware_hwver = 7 needs to be specified to enable both features.
>>>
>>> vmware_hwver = 7 is special because that is what controls the
>>> enable of CPUID leaves for VMware (vmware_hwver >= 7).
>>>
>>> Note: vmware_port and nestedhvm cannot be specified at the
>>> same time.
>>>
>>> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
>>
>> Ian:
>>
>> So I *think* it may be the case that this patch only depends on patch 5
>> to apply.  I also think that patches 5 and 7 together add another useful
>> "chunk" of functionality (core vmport functionality for guest OSes).
> 
> Is there any point in this chunk without 1..3?
> 
> 

There may be.  However changes would need to be done if 2 and 3 are not
present.

Patch #1 is independent.

Pacth 2,3 provide CPUID support, which is not always needed.

Just 5,7 and 8 may work to provide X windows usage of vmware mouse.  I
have not tested with just this set.  This is because most Xservers run
with IOPL set to 3 and so do not need patch #6.  My memory also says
that CPUID support is not needed (which is what you get for vmware_hwver=3).


   -Don Slutz

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel