[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v11 3/9] tools: Add vmware_hwver support
On 06/04/15 11:17, Ian Campbell wrote: > On Fri, 2015-05-22 at 11:50 -0400, Don Slutz wrote: >> [...] >> +=item B<vmware_hwver=NUMBER> >> + >> +Turns on or off the exposure of VMware cpuid. The number is >> +VMware's hardware version number, where 0 is off. A number >= 7 >> +is needed to enable exposure of VMware cpuid. >> + >> +The hardware version number (vmware_hwver) come from VMware config files. > > "comes" > Will fix. >> diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c >> index 38d065f..4362d5d 100644 >> --- a/tools/libxc/xc_domain.c >> +++ b/tools/libxc/xc_domain.c >> @@ -64,7 +64,7 @@ int xc_domain_create(xc_interface *xch, >> memset(&config, 0, sizeof(config)); >> >> #if defined (__i386) || defined(__x86_64__) >> - /* No arch-specific configuration for now */ >> + /* No arch-specific default configuration for now */ > > I'm not sure this hunk has anything to do with this patch, nor what the > semantic difference between the old and new text is supposed to be. > I do not have to make this change. However I feel the comment is misleading, and I changed it. The real change is later: diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c index 651b338..fd7dafa 100644 --- a/tools/libxl/libxl_x86.c +++ b/tools/libxl/libxl_x86.c @@ -5,8 +5,7 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, libxl_domain_config *d_config, xc_domain_configuration_t *xc_config) { - /* Note: will be changed in a later patch */ - xc_config->vmware_hwver = 0; + xc_config->vmware_hwver = d_config->c_info.vmware_hwver; return 0; } which is where "arch-specific configuration" is done. This is where the default "arch-specific configuration" is done. -Don Slutz > Ian. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |