Re: [Xen-devel] [OSSTEST v6 13/24] distros: support PV guest install from Debian netinst media.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-05-12 at 16:52 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[OSSTEST v6 13/24] distros: support PV guest install 
> from Debian netinst media."):
> > The netinst media are iso images containing a base Debian install and
> > some (image size dependent) additional tasks.
> 
> Most of this looks good to me.
> 
> > +   amd64 => { PathArch => "multi-arch", FileArch => "amd64-i386", IsoPath 
> > => "/install.amd/xen" },
> > +   i386  => { PathArch => "multi-arch", FileArch => "amd64-i386", IsoPath 
> > => "/install.386/xen" },
> > +   armhf => { PathArch => "armhf",      FileArch => "armhf",      IsoPath 
> > => "/install.armhf" }
> 
> Wrap damage on my screen.  I appreciate that you want to retain the
> tabular nature, but perhaps 
> 
>     my %arch_props = (
>       amd64 => [ "multi-arch", "amd64-i386", "/install.amd/xen" },
>       i386  => [ "multi-arch", "amd64-i386", "/install.386/xen" },
>       armhf => [ "armhf",      "armhf",      "/install.armhf" },
>         )
>     my           ( $path_arch,   $file_arch,   $iso_path ) =
>         @{ $arch_props{$arch} };
> 
> Or something ?

More Perl-fu than I could muster by myself, but looks good to me ;-)

> > +    my $baseurl = $cd eq "current" ?
> > +      
> > "http://cdimage.debian.org/debian-cd/current/$props->{PathArch}/jigdo-cd" :
> > +      
> > "http://cdimage.debian.org/cdimage/weekly-builds/$props->{PathArch}/jigdo-cd";
> 
> This should surely come from a runvar (or perhaps a config option)
> rather than being hardcoded.

$cd above came from $r{"$gho->{Guest}_cd"} and takes the values either
"current" or "weekly".

I could push the logic which mas those to an actual URL into
make-distros-flight if you would prefer? Or perhaps push the two
prefixes (up to but not including "$props->.../jigdo-cd") into the cfg
file? So it would become "$c{DebianCdURL_
$cd}/$props->{PathArch}/jigdo-cd"

The latter sounds a bit preferable I think, hardcoding URLs in
make-flight seems as wrong as hardcoding them here.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel