Re: [Xen-devel] [PATCH] xen/vm_event: Clean up control-register-write vm_events

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/05/15 16:50, Andrew Cooper wrote:
> On 12/05/15 16:49, Razvan Cojocaru wrote:
>> On 05/12/2015 06:35 PM, Jan Beulich wrote:
>>>>>> On 12.05.15 at 16:58, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>>> +/* Supported values for the vm_event_write_ctrlreg index. */
>>>> +#define X86_CR0     (1 << 0)
>>>> +#define X86_CR3     (1 << 1)
>>>> +#define X86_CR4     (1 << 2)
>>>> +#define X86_XCR0    (1 << 3)
>>> These names, being put in the public interface, are way too generic.
>> I've copied them from Andrew Cooper's suggestion in the previous thread,
>> hopefully he'll chime in. I'm happy to rename / move them if so desired.
> I intended something like VM_EVENT_ARCH_X86_CR0 etc.

or perhaps slightly more specific to ctrl_reg read/write.

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel