Re: [Xen-devel] [PATCH 2/7] docs/build: Do not open-code $*

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.04.15 at 13:55, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 20/04/15 12:48, Jan Beulich wrote:
>>>>> On 20.04.15 at 12:49, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> --- a/docs/Makefile
>>> +++ b/docs/Makefile
>>> @@ -73,13 +73,11 @@ endif
>>>  
>>>  man1/%.1: man/%.pod.1 Makefile
>>>     $(INSTALL_DIR) $(@D)
>>> -   $(POD2MAN) --release=$(VERSION) --name=`echo $@ | sed 's/^man1.//'| \
>>> -           sed 's/.1//'` -s 1 -c "Xen" $< $@
>>> +   $(POD2MAN) --release=$(VERSION) --name=$* -s 1 -c "Xen" $< $@
>> This is a change in quoting, and while benign now maybe it would be
>> better to add back quotation marks?
> 
> Are you sure? The result of the `` was not previously quoted, which is
> why I left it unquoted across the change.

The invocation via `' itself is a kind of quoting, i.e. the result will
not be subject to things like parameter expansion and filename
globbing by the shell.

> If quoting were an issue, all rules would need updating for $*, $< and $@

That's true, so perhaps still fine as is.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel