Re: [Xen-devel] [PATCH 2/7] docs/build: Do not open-code $*

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/04/15 12:48, Jan Beulich wrote:
>>>> On 20.04.15 at 12:49, <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/docs/Makefile
>> +++ b/docs/Makefile
>> @@ -73,13 +73,11 @@ endif
>>  
>>  man1/%.1: man/%.pod.1 Makefile
>>      $(INSTALL_DIR) $(@D)
>> -    $(POD2MAN) --release=$(VERSION) --name=`echo $@ | sed 's/^man1.//'| \
>> -            sed 's/.1//'` -s 1 -c "Xen" $< $@
>> +    $(POD2MAN) --release=$(VERSION) --name=$* -s 1 -c "Xen" $< $@
> This is a change in quoting, and while benign now maybe it would be
> better to add back quotation marks?

Are you sure? The result of the `` was not previously quoted, which is
why I left it unquoted across the change.

If quoting were an issue, all rules would need updating for $*, $< and $@

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel