Re: [Xen-devel] [PATCH 02/19] xen: arm: add missing break

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 16/04/2015 17:08, Ian Campbell wrote:
> On Thu, 2015-04-02 at 16:09 +0100, Julien Grall wrote:
> > Hi Ian,
> >
> > On 31/03/2015 11:07, Ian Campbell wrote:
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > >
> > > xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1
> > >
> > > Having injected an undefined instruction we don't want to also advance
> > > pc. So return.
> > >
> > > THe ICC_{SGI0R,ASGI1R}_EL1 case was previously missing a break, so
> > > would have fallen through to the default case and injected a second
> > > undef, corrupting SPSR_EL1 and ELR_EL1 for the guest.
> > >
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Thanks. I seem to have two commit messages for this one, I think from a
> botched patch squash.
>
> I've dropped the "add missing break" commit message, since I've actually
> written about it in the final paragraph. I've kept your R-by regardless,
> which I hope is ok.
I'm fine with the change.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel