Re: [Xen-devel] [PATCH 0/2] Re-factoring passthrough/pci.c and adding place-holder code for ARM/PCI

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-04-14 at 10:34 +0100, Stefano Stabellini wrote:
> On Tue, 14 Apr 2015, Jaggi, Manish wrote:
> > Hi Julien,
> >
> > From: Julien Grall <julien.grall.oss@xxxxxxxxx>
> > Sent: Monday, April 13, 2015 3:49 PM
> > To: Jaggi, Manish; xen Devel; Stefano Stabellini; Julien Grall; Ian 
> > Campbell; Kumar, Vijaya; Prasun.kapoor@xxxxxxxxxx
> > Subject: Re: [Xen-devel] [PATCH 0/2] Re-factoring passthrough/pci.c and 
> > adding place-holder code for ARM/PCI
> > 
> > Hi Manish,
> > 
> > On 13/04/15 08:37, Manish Jaggi wrote:
> > > Xen currently does not have PCI support for ARM builds. This patch set
> > > makes the code compilable for ARM PCI and adds places-holder code
> > > which would be replaced with PCI pass-through support patch series.
> > 
> > May I ask why you did send directly all the code to support PCI on ARM?
> > 
> > Without the rest it's hard to tell whether these patches make sense or not.
> >
> > [Manish] As I have mentioned these two patches are only for refactoring msi 
> > specific  functions to x86 files and providing the constructs that make PCI 
> > ARM code compilable.
> > 
> > The code for PCI ARM is very basic in the patch and PCI passthrough code 
> > patches will follow in next series. Please let me know which code does not 
> > makes sense and I will modify it.
> 
> On the face if it, it makes sense, and I understand that you are doing
> this to just build Xen on ARM with HAS_PCI.
> 
> However it is hard to understand the full picture, how all the pieces
> fit together, without the rest. I think it would make sense to place
> these two patches at the beginning of your longer series.

I agree.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel