[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCHv2 3/6] xen: generic xadd() for ticket locks



>>> On 10.04.15 at 16:19, <david.vrabel@xxxxxxxxxx> wrote:
> +#define xadd(ptr, v) generic_xaddl((ptr), (v))

I think it is at least confusing to call the thing xadd (looking to be
size generic) and then expand to generic_xaddl (only supporting
32-bit operations), yet subsequently implementing a size-generic
xadd() for x86. Plus the extra parentheses should be removed
to not needlessly obfuscate things.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.