Re: [Xen-devel] [PATCHv2 1/6] x86/hvm: don't include asm/spinlock.h

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 10/04/15 16:24, Andrew Cooper wrote:
> On 10/04/15 15:19, David Vrabel wrote:
>> asm/spinlock.h should not be included directly.
>>
>> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> s/asm/xen/g instead of a straight delete?
> 
> Otherwise you are relying on pulling in xen/spinlock.h implicitly.

None of these files declare a spinlock so getting the header implicitly
is correct, IMO.

David

>>  xen/arch/x86/hvm/hvm.c     |    1 -
>>  xen/arch/x86/hvm/svm/svm.c |    1 -
>>  xen/arch/x86/hvm/vmx/vmx.c |    1 -


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel