Re: [Xen-devel] [PATCHv2 1/6] x86/hvm: don't include asm/spinlock.h

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/04/15 15:19, David Vrabel wrote:
> asm/spinlock.h should not be included directly.
>
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

s/asm/xen/g instead of a straight delete?

Otherwise you are relying on pulling in xen/spinlock.h implicitly.

~Andrew

> ---
>  xen/arch/x86/hvm/hvm.c     |    1 -
>  xen/arch/x86/hvm/svm/svm.c |    1 -
>  xen/arch/x86/hvm/vmx/vmx.c |    1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 4734d71..6937857 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -52,7 +52,6 @@
>  #include <asm/xstate.h>
>  #include <asm/traps.h>
>  #include <asm/mc146818rtc.h>
> -#include <asm/spinlock.h>
>  #include <asm/mce.h>
>  #include <asm/hvm/hvm.h>
>  #include <asm/hvm/vpt.h>
> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
> index b6e77cd..6734fb6 100644
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -41,7 +41,6 @@
>  #include <asm/msr.h>
>  #include <asm/i387.h>
>  #include <asm/iocap.h>
> -#include <asm/spinlock.h>
>  #include <asm/hvm/emulate.h>
>  #include <asm/hvm/hvm.h>
>  #include <asm/hvm/support.h>
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index e1c55ce..2a0610b 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -35,7 +35,6 @@
>  #include <asm/types.h>
>  #include <asm/debugreg.h>
>  #include <asm/msr.h>
> -#include <asm/spinlock.h>
>  #include <asm/paging.h>
>  #include <asm/p2m.h>
>  #include <asm/mem_sharing.h>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel