Re: [Xen-devel] [PATCH v4 08/12] x86: dynamically get/set CBM for a domain

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Thu, Apr 09, 2015 at 11:06:45PM +0100, Andrew Cooper wrote:
> On 09/04/2015 10:18, Chao Peng wrote:
> > +        find->cbm = cbm;
> > +    }
> > +    find->ref++;
> > +    map[old_cos].ref--;
> 
> This can race with psr_free_cos() leading to corruption.  It is possible
> for two different domains to be holding their own spinlock but using the
> same cos index.
> 
> You definitely do need a psr/cos spinlock for safety.

Indeed. Thanks.

Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel