Re: [Xen-devel] [PATCH v4 06/12] x86: add COS information for each domain

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Thu, Apr 09, 2015 at 10:54:00PM +0100, Andrew Cooper wrote:
> On 09/04/2015 10:18, Chao Peng wrote:
> > +    {
> > +        d->arch.psr_cos_ids = xzalloc_array(unsigned int, nr_sockets);
> 
> It is perhaps worth leaving a comment in patch 3 stating that nr_sockets
> must never change after domains have been created.
> 
> That, or whomever implements CAT/socket hotplug support has to fix this
> issue.  (I think the code is fine to leave in its current state, but
> nr_sockets changing under the feet of Xen will be a subtle bug for
> someone to track down)
> 
> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

That's right, keep nr_sockets as constant at runtime is the basic
assumption.

Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel