Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-03-24 at 15:12 +0000, Julien Grall wrote:
> Hi Ian,
> 
> On 24/03/2015 14:20, Ian Campbell wrote:
> > @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
> >           break;
> >       default:
> >           {
> > -#ifndef NDEBUG
> >               struct hsr_cp64 cp64 = hsr.cp64;
> >
> >               gdprintk(XENLOG_ERR,
> > @@ -1718,7 +1715,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
> >                        cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc);
> >               gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n",
> >                        hsr.bits & HSR_CP64_REGS_MASK);
> > -#endif
> 
> Did you try to build with debug=n ? I suspect that GCC will warn about 
> the unused cp64.

I did, and it didn't.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel