[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()



Hi Jan,

On 24/03/2015 15:31, Jan Beulich wrote:
On 24.03.15 at 16:12, <julien.grall@xxxxxxxxxx> wrote:
Hi Ian,

On 24/03/2015 14:20, Ian Campbell wrote:
@@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
           break;
       default:
           {
-#ifndef NDEBUG
               struct hsr_cp64 cp64 = hsr.cp64;

               gdprintk(XENLOG_ERR,
@@ -1718,7 +1715,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
                        cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc);
               gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n",
                        hsr.bits & HSR_CP64_REGS_MASK);
-#endif

Did you try to build with debug=n ? I suspect that GCC will warn about
the unused cp64.

I don't think so - gdprintk() in the NDEBUG case is specifically an
inline function instead of a macro, to avoid this very issue.

I wasn't sure about it. So

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.