[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/iommu: fix usage of shared EPT/IOMMU page tables on PVH guests

>>> On 27.02.15 at 11:10, <roger.pau@xxxxxxxxxx> wrote:
> iommu_share_p2m_table should not prevent PVH guests from using a shared page
> table. Change the condition to has_hvm_container_domain instead of
> is_hvm_domain. This allows both PVH and HVM guests to use it. Remove the
> asserts in iommu_set_pgd and amd_iommu_share_p2m, iommu_share_p2m_table
> and p2m_alloc_table already do them.

This wording is confusing - it took me to got into p2m_alloc_table()
to see that one half of the assertion is being satisfied there an
the other in iommu_share_p2m_table(). While not asserting what
IOMMU code does is quite fine in IOMMU code (especially as closely
related as is the case here), the assertion regarding what P2M
code does (and what a future second caller of
iommu_share_p2m_table() might violate) should be kept, but
perhaps be moved into iommu_share_p2m_table() instead of
keeping it in vendor specific code.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.