[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/1] xen-netback: remove compilation warning

From: pedro <marzo.pedro@xxxxxxxxx>
Date: Thu, 26 Feb 2015 09:25:41 +0100

> From: pmarzo <marzo.pedro@xxxxxxxxx>
> offset and size are of type uint16_t so the %lu gives a warning
> A %u specifier, the same used in size makes gcc happy
> Not sure if a %x would be more correct
> Signed-off-by: Pedro Marzo Perez <marzo.pedro@xxxxxxxxx>

This patch actually adds a warning on my machine, and your analysis
of the types is therefore probably incorrect:

drivers/net/xen-netback/netback.c: In function ʽxenvif_tx_build_gopsʼ:
drivers/net/xen-netback/netback.c:1259:8: warning: format ʽ%uʼ expects argument 
of type ʽunsigned intʼ, but argument 5 has type ʽlong unsigned intʼ [-Wformat=]

The issue is probably "~PAGE_MASK" and I think the type of that
propagates into the type of the overall calculation.
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.