[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH DOCDAY] netif.h: describe request/response structures in terms of binary layout

On Wed, Feb 25, 2015 at 12:16:50PM +0000, Ian Campbell wrote:
> In RFC style, rather than relying on the implicit assumptions of a
> particular C ABI.
> I have also confirmed, using the Python gdb extension technique in
> [0], that the struct offsets (in a Linux binary at least) are the same
> as described here.
> I took the opportunity to also confirm that x86_32, x86_64, arm32 and
> arm64 are all the same.
> This highlighted that struct netif_rx_request was missing some
> explicit padding, which is added here.
> Lastly, fixup some struct names to allow the generated docs to
> properly hyperlink, mainly by adding the _t to type names where
> appropriate, but also s/netif_tx_extra/netif_extra_info_t/.
> [] 
> http://stackoverflow.com/questions/9788679/how-to-get-the-relative-adress-of-a-field-in-a-structure-dump-c,

Missing "0" and extraneous comma at the end.

> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

The rest looks good to me. Thanks for doing this.

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.