[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES



>>> On 24.02.15 at 10:38, <julien.grall@xxxxxxxxxx> wrote:
> On 24/02/2015 09:31, Ian Campbell wrote:
>> On Wed, 2015-02-18 at 13:03 +0000, Julien Grall wrote:
>>>> +                {
>>>> +                    pte = mfn_to_xen_entry(mfn, (ai & 0xffff));
>>>
>>> Please introduce a new macro for the mask.
>>
>> Better would be a pte_foo accessor, similar (if not identical) to x86's
>> pte_get_flags. So pte_get_flags(ai) or so.
> 
> I'm not able to find a such function in x86. Did you intend to mean 
> pte_flags_to_cacheattr?

get_pte_flags()

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.