[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 21/24] tools/(lib)xl: Add partial device tree support for ARM

Julien Grall writes ("Re: [PATCH v3 21/24] tools/(lib)xl: Add partial device 
tree support for ARM"):
> On 23/02/15 12:03, Ian Jackson wrote:
> > Please wrap your commit messages to 70, not 80.
> I though commit message has to be wrapped to 80. I will change it.

Thanks.  `git log' adds 4 spaces, and email quoting adds varying
numbers of `> ', so the original has to be significantly less than 80
to stop quoted emails and git log from being too wide (by which I mean
more than 79).

> > This is rather odd.  The config option is `device_tree' but apparently
> > it is only relevant for passthrough and nothing else can be set with
> > it.
> I had to chose a name for the node and "/passthrough" was the best one
> and it won't collapse with the device tree generated by the toolstack.
> Although, you can put pretty much everything in the "/passthrough" node.

Perhaps the config option should be renamed so that it's less
general.  Maybe in future people will want a more general dtb-editing
facility and then this would be in the way.

> It's not my plan to have an XSA-55 like :).


> As discussed IRL, we can mark this option "unsafe". So any device tree
> pass to libxl should be trusted.


> I will add an item in the description.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.