Re: [Xen-devel] [PATCH v9 05/13] xen: Add vmware_port support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.02.15 at 17:03, <dslutz@xxxxxxxxxxx> wrote:
> On 02/23/15 10:05, Jan Beulich wrote:
>>>>> On 17.02.15 at 00:05, <dslutz@xxxxxxxxxxx> wrote:
>>> This includes adding is_vmware_port_enabled
>>>
>>> This is a new domain_create() flag, DOMCRF_vmware_port.  It is
>>> passed to domctl as XEN_DOMCTL_CDF_vmware_port.
>> 
>> As indicated before, I don't think this is a good use case for a
>> domain creation flag. Some of the others we have may not be either,
>> but as I have said quite often recently - let's not make the situation
>> worse by following bad examples.
>> 
> 
> I was not sure on the way to go based on the emails.

I think I said so before - we should come to some conclusion among
maintainers here first. I'm afraid besides Andrew and me no-one
really voiced any opinion; maybe worth for you to send out a
separate request-for-comments on this specific aspect...

>>> +        case BDOOR_CMD_GETVERSION:
>>> +            /* MAGIC */
>>> +            regs->_ebx = BDOOR_MAGIC;
>>> +            /* VERSION_MAGIC */
>>> +            new_eax = 6;
>>> +            /* Claim we are an ESX. VMX_TYPE_SCALABLE_SERVER */
>>> +            regs->_ecx = 2;
>> 
>> Are you sure you don't want to zero the high halves of 64-bit
>> registers here?
>> 
> 
> Yes, VMware does not zero the high halves.

Which then again calls for a comment so that a casual reader won't
be tempted to "fix" this (non-architectural) behavior.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel