Re: [Xen-devel] [PATCH v3 17/24] xen/passthrough: arm: release earlier the DT devices assigned to a guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.02.15 at 16:33, <ian.campbell@xxxxxxxxxx> wrote:
> On Mon, 2015-02-23 at 09:37 +0000, Jan Beulich wrote:
>> >>> On 20.02.15 at 18:46, <julien.grall@xxxxxxxxxx> wrote:
>> > On 20/02/15 17:03, Ian Campbell wrote:
>> >> On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote:
>> >> 
>> >> Subject: "release the DT devices assigned to a guest earlier"
>> >> 
>> >>> The toolstack may not have deassign every device used by a guest.
>> >> 
>> >> "deassigned"
>> >> 
>> >>> Therefore we have to go through the device list and removing them before
>> >> 
>> >> "and remove them"
>> >> 
>> >>> asking the IOMMU drivers to release memory for this domain.
>> >>>
>> >>> This can be done by moving the call to the release function when we
>> >>> relinquish the resources. The IOMMU part will be destroyed later when
>> >>> the domain is freed.
>> >>>
>> >>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> >>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>> >> 
>> >> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> >> 
>> >> I'd like to hear Jan's opinion though.
>> > 
>> > FWIW, this is how it's done for PCI.
>> 
>> Right, IOW I agree to the idea of the patch.
> 
> Thanks. If Julien could record this in the form of an ack that would
> save me remembering you've said so (otherwise it could just go as a
> comment after the --- I suppose).

That's fine with me, I just didn't say so because it seemed a bit
odd on an ARM-only change.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel