Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 23/02/15 15:31, Ian Campbell wrote:
> On Fri, 2015-02-20 at 17:45 +0000, Julien Grall wrote:
>> On 20/02/15 16:58, Ian Campbell wrote:
>>> On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote:
>>>> This new function will correctly initialize the IOMMU page table for the
>>>> current domain.
>>>>
>>>> Also use it in iommu_assign_dt_device even though the current IOMMU
>>>> implementation on ARM shares P2M with the processor.
>>>>
>>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>>>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>>>
>>> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>>>
>>> Although I'm not actually sure what it is going to be used for.
>>
>> The caller are in this patch too :) (see pci.c and device_tree.c changes).
> 
> Right, I meant "what non-trivial functionality is going to land here"
> i..e what the grandparent callers etc will eventually expect from it.

Oh ok. The function is used to the prepare the IOMMU structure for the
domain. Currently, the steps are:
        - build the page table on platforms which don't share the P2M
        - set need_iommu to 1.

Within this series, this is the only patch who touch this function.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel