[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 14/24] xen/dts: Use unsigned int for MMIO and IRQ index

Hi Ian,

On 20/02/15 16:55, Ian Campbell wrote:
> On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote:
>> There is no reason to use signed integer for an index.
> Did you check for now pointless "if ( uthing < 0 ) which a picky
> compiler might whinge about?

I just checked and we don't have a such test in those function.

BTW, I think clang is picky on pointless if ( ufoo < 0 ) but we don't
support it on ARM right now.

>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.