[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v18 14/16] x86/VPMU: NMI-based VPMU support

>>> On 16.02.15 at 23:26, <boris.ostrovsky@xxxxxxxxxx> wrote:
> +int pmu_nmi_interrupt(const struct cpu_user_regs *regs, int cpu)


> +{
> +    return vpmu_do_interrupt(regs);

That function returning 1 makes do_nmi() not do _anything_ else, i.e.
ignore eventual SERR or IOCHK events. That's not acceptable. I guess
you'll need to make nmi_callback() return values tristate and adjust
do_nmi() to deal with both cases. Albeit - the other two users are
breaking this too, so perhaps do_nmi() should be adjusted in a prereq
(and backportable) patch to not bail in that case. Yet a tristate may
still be needed, since alternative_instructions() legitimately wants to
suppress them getting handled - it would just need to invoke their
handling once done with patching.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.