[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 08/13] xen/arm: Describe device supported by a driver with dt_match_node

On Fri, 2015-01-30 at 18:49 +0000, Julien Grall wrote:

Subject: "devices"

> Xen is currently using list a compatible string to know if the driver

"using a list of compatible strings"

rather than "if the driver can use device node" I'd say something like
"to match drivers against device nodes".

> can use device node. This leads to have double definition in the GIC
> code.

"having double definitions".

(aside: can we eventually get rid of that duplication somehow?)

> Futhermore Linux drivers is using dt_match_node (actually called of_device_id

"Furthermore" and "are using"

> in Linux) to list device supported by the drivers.


I'd append one more sentence, something like "Remove the existing
compatible field and replace with a dt_match field". Just to make it
clear what the change here is.

> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

The actual code looks fine, with the commit message fixed up as

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.