[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for 4.6 13/13] xen/iommu: smmu: Add Xen specific code to be able to use the driver

On 18/02/2015 17:30, Jaggi, Manish wrote:
[manish] There are general comments on the data structures
(a) I don't see a use case where for same domain (VM) there would be different 
context banks , so linked list may not be required.

I guess you mean the list in arm_smmu_xen_domain? All the devices pass-through to a domain may not be protected by the same SMMU. Therefore the context banks are different.

Also, for now a context is allocated per-device. It should be rework to share the context between multiple device protected by the same SMMU and pass-through to the same domain.

(b) Also iommu group may not be relevant for the same reason.
I am curious to find the use cases.

The iommu_group is used to store the configuration of the device protected by an SMMU (i.e the stream ids associated to this domain).

I'm a bit surprised that you think they are not useful...


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.