[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V6 04/13] xen: Rename mem_event to vm_event

On Wed, Feb 18, 2015 at 2:35 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 18.02.15 at 13:21, <tamas.k.lengyel@xxxxxxxxx> wrote:
>> On Wed Feb 18 2015 10:46:02 AM CET, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>> > > > On 18.02.15 at 01:11, <tamas.lengyel@xxxxxxxxxxxx> wrote:
>>> > diff --git a/xen/common/mem_event.c b/xen/common/vm_event.c
>>> > similarity index 59%
>>> > rename from xen/common/mem_event.c
>>> > rename to xen/common/vm_event.c
>>> Looking at this already quite huge delta I can't really see why
>>> adjusting white space at once would make it much worse. In any
>>> case better than leaving white space damage behind.
>> I did that in the first version of the patch and the feedback I got was that
>> it is unreviewable that way.
> Not really - in the first version of the patch the old file gets removed
> as a whole, and the new file added. Same in v2 afaics, where indeed
> you got such a comment.
> Jan

I would rather prefer it all being done in one patch but unfortunately
git can't keep track of the code movement that way. I'm not aware of
any option to git to achieve all this in one patch.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.