[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 1/5] iommu: need_iommu set early

On Tue, Feb 17, 2015 at 12:46:40PM +0000, Jan Beulich wrote:
> >>> On 13.02.15 at 19:51, <elena.ufimtseva@xxxxxxxxxx> wrote:
> > Set need_iommu for dom0 early so pvh specific functions
> > in construct_dom0 can pass this check.
> > See example in p2m-ept.c ept_set_entry.
> > 
> > Signed-off-by: Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>
> Having gone through the rest of this series, I can't see the relation
> and I also can't see why this would be needed all of the sudden. I
> was considering to apply this on its own, but without a proper
> explanation of why it's needed I don't think I should.

After analysing once more I can see that this change is needed
only with this patchset. If the command-line defined extra RMRRs are 
being mapped in hwdom_iommu_init, at that point the entries will be
mapped with iommu as need_iommu will be set to 1.

I will work on the changes regarding extr RMRRs and get rid of this

> Jan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.