Re: [Xen-devel] [PATCH OSSTEST 11/12] Changes on test step of debain hvm guest install

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Feb 17, 2015 at 10:37:39AM +0000, Wei Liu wrote:
> On Tue, Feb 17, 2015 at 12:45:34AM +0000, Hu, Robert wrote:
> [...]
> > > 
> > > > Am I supposed to wait for Wei's patch or use my approach for a while and
> > > > revert to Wei's patch afterwards?
> > > 
> > > What patch do you expect from me?
> > That Ian mentioned above 
> > 'unify the d-i partman-auto/expert_recipe
> > in Debian.pm with the one in ts-debian-hvm-install, and make all
> > Debian HVM installations use LVM.'
> 
> I'm afraid I don't have time to do the refactoring and testing any time
> soon.
> 
> I had a look at d-i's preseed documentation. And this is what I come up
> with. Note it's untested patch, just a proof-of-concept what the final
> recipe might look like.
> 
> A proper upstream patch will require factoring out the common bits first
> (/boot, / and swap) and then append test case specific bits (in this
> case, the EFI boot partition) later.
> 
> Wei.
> 
> diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install
> index 449b96c..e87a2c0 100755
> --- a/ts-debian-hvm-install
> +++ b/ts-debian-hvm-install
> @@ -54,6 +54,12 @@ d-i partman-auto/method string  regular
> 
>  d-i partman-auto/expert_recipe string \\
>          boot-root :: \\
> +                100 50 100 ext4
> +                       \$primary{ } \$bootable{ }                      \\
> +                       method{ format } format{ }                      \\
> +                       use_filesystem{ } filesystem{ ext3 }            \\
                                                        ext4

Copy and paste error, sorry.

> +                       mountpoint{ /boot }                             \\
> +               .                                                       \\
>                  512 50 512 vfat \\
>                          \$primary{ } \$bootable{ } \\
                                          ^^^^^^^^
And you might want to get rid of this bootable flag.

The testing of this patch will require you to run at least
test-amd64-amd64-xl-qemuu-{debianhvm,ovmf}-amd64.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel