Re: [Xen-devel] [PATCH v5 05/24] libxc: allocate memory with vNUMA information for PV guest

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Feb 16, 2015 at 04:58:11PM +0000, Dario Faggioli wrote:
> On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote:
> 
> > @@ -760,7 +760,8 @@ static int x86_shadow(xc_interface *xch, domid_t domid)
> >  int arch_setup_meminit(struct xc_dom_image *dom)
> >  {
> >      int rc;
> > -    xen_pfn_t pfn, allocsz, i, j, mfn;
> > +    xen_pfn_t pfn, allocsz, mfn, total, pfn_base;
> > +    int i, j;
> >  
> >      rc = x86_compat(dom->xch, dom->guest_domid, dom->guest_type);
> >      if ( rc )
> > @@ -811,26 +812,101 @@ int arch_setup_meminit(struct xc_dom_image *dom)
> >              if ( rc )
> >                  return rc;
> >          }
> > -        /* setup initial p2m */
> > -        dom->p2m_size = dom->total_pages;
> > +
> > +        /* Setup dummy vNUMA information if it's not provided. Note
> > +         * that this is a valid state if libxl doesn't provide any
> > +         * vNUMA information.
> > +         *
> > +         * The dummy values make libxc allocate all pages from
> > +         * arbitrary physical. This is the expected behaviour if no
> > +         * vNUMA configuration is provided to libxc.
> > +         *
> "from arbitrary phisical nodes" maybe (or something like that?)
> 

Fixed. Thanks.

Wei.

> Also, it feels like these two paragraphs can be merged into one. Not a
> bit deal, though, and the rest of the patch also looks fine.
> 
> Regards,
> Dario



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel