Re: [Xen-devel] [PATCH] xen/Coverity: Audit of MISSING_BREAK defects

[Don Koch <dkoch@xxxxxxxxxxx>]

On Fri, 13 Feb 2015 11:01:27 +0000
Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:

> On 12/02/15 21:06, Don Koch wrote:
> > On Thu, 12 Feb 2015 20:08:46 +0000
> > Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> >
[...]
> > I'm surprised that coverity didn't complain about the fallthrough in
> > the next case:
> >
> >     case TASKLET_scheduled:
> >         clear_bit(_TASKLET_scheduled, tasklet_work);
> >     case 0:
> >         /*tasklet_work_scheduled = 0;*/
> >         break;
> >
> > Or is my code out of date?
> >
> > With or without that change,
> > Reviewed-by: Don Koch <dkoch@xxxxxxxxxxx>
> 
> Another heuristic is a case statement followed by another case which
> begins with a break.  The defect would re-emerge if code gets uncommented.

Gotcha. My R-b still stands.

Thanks,
-d

> ~Andrew
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel