[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 3/7] sysctl: Make topologyinfo and numainfo sysctls a little more efficient

On 02/13/2015 07:26 AM, Wei Liu wrote:
On Mon, Feb 09, 2015 at 03:04:31PM -0500, Boris Ostrovsky wrote:
Currently both of these sysctls make a copy to userspace for each index of
various query arrays. We should try to copy whole arrays instead.

This requires some changes in sysctl's public data structure, thus bump
interface version.

Report topology for all present (not just online) cpus.

Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the fact
that these are used for CPU topology. Subsequent patch will add support for
PCI topology sysctl.

Clarify some somments in sysctl.h.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  tools/libxc/include/xenctrl.h     |    4 +-
  tools/libxc/xc_misc.c             |   10 ++--
  tools/libxl/libxl.c               |   71 +++++++------------
  tools/misc/xenpm.c                |   69 +++++++-----------
  tools/python/xen/lowlevel/xc/xc.c |   77 ++++++++------------
Are these mostly mechanical changes? I'm assuming yes.

Pretty much, yes.


  xen/common/sysctl.c               |  141 ++++++++++++++++++++++---------------
  xen/include/public/sysctl.h       |   75 ++++++++++++--------
  7 files changed, 221 insertions(+), 226 deletions(-)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.