[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 08/24] libxl: introduce libxl__vnuma_config_check

Wei Liu writes ("[PATCH v5 08/24] libxl: introduce libxl__vnuma_config_check"):
> This function is used to check whether vNUMA configuration (be it
> auto-generated or supplied by user) is valid.

This looks plausible, but I think you should explain what the impact
of this patch is.  Presumably the intent is to replace various later
failures with ERROR_FAIL with something more useful and more
specific ?

Are there any cases which this new check forbids but which are
currently accepted by libxl ?  If so then we have to think about

Also I would like to see an ack from the authors of the vnuma support,
as I'm not familiar enough with vnuma to fully understand the
semantics of the new checks.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.