Re: [Xen-devel] [PATCH OSSTEST 07/12] For hvm guest configuration, config console to 'hvc0'

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Robert Ho writes ("[PATCH OSSTEST 07/12] For hvm guest configuration, config 
console to 'hvc0'"):
> ---
>  Osstest/TestSupport.pm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index c23bbc7..864805e 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -1753,7 +1753,11 @@ sub target_kernkind_check ($) {
>      if ($kernkind eq 'pvops') {
>          store_runvar($pfx."rootdev", 'xvda') if $isguest;
>          store_runvar($pfx."console", 'hvc0');
> -    } elsif ($kernkind !~ m/2618/) {
> +    }
> +    elsif ($kernkind eq 'hvm'){
> +        store_runvar($pfx."console", 'hvc0');       #nested hvm guest shall 
> not append console=xvc0; I guess this applies to all hvm guests.
> +    }
> +    elsif ($kernkind !~ m/2618/) {

I don't understand why this is necessary.  Surely all the kernels here
are pvops so the kernkind should be 'pvops' in all cases and the
console will be set to hvc0 anyway ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel