[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 1/7] x86/numa: Make use of NUMA_NO_NODE consistent




On 02/10/2015 06:39 AM, Jan Beulich wrote:
On 09.02.15 at 21:04, <boris.ostrovsky@xxxxxxxxxx> wrote:
--- a/xen/include/asm-x86/numa.h
+++ b/xen/include/asm-x86/numa.h
@@ -21,7 +21,7 @@ struct node {
extern int compute_hash_shift(struct node *nodes, int numnodes,
                              int *nodeids);
-extern int pxm_to_node(int nid);
+extern u8 pxm_to_node(int nid);
Perhaps introduce nodeid_t, so that once needed it can be widened?

Yes. I actually thing there are more references to node IDs throughout the code that may need adjusting.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.