[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V4 02/13] xen/mem_event: Cleanup mem_event ring names and domctls

>>> On 09.02.15 at 19:53, <tamas.lengyel@xxxxxxxxxxxx> wrote:
> The name of one of the mem_event rings still implies it is used only
> for memory accesses, which is no longer the case. It is also used to
> deliver various HVM events, thus the name "monitor" is more appropriate
> in this setting.
> The mem_event subop definitions are also shortened to be more meaningful.
> The tool side changes are only mechanical renaming to match these new names.
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

For the small parts this is relevant for and with one remark (below):
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> @@ -510,9 +510,9 @@ void mem_event_cleanup(struct domain *d)
>      }
>  #endif
>  #ifdef HAS_MEM_ACCESS
> -    if ( d->mem_event->access.ring_page ) {
> -        destroy_waitqueue_head(&d->mem_event->access.wq);
> -        (void)mem_event_disable(d, &d->mem_event->access);
> +    if ( d->mem_event->monitor.ring_page ) {

Please fix coding style issues when you need to touch code anyway.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.