Re: [Xen-devel] [RFC PATCH V3 10/12] xen: Introduce monitor_op domctl

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

>>> --- a/xen/include/public/hvm/params.h
>>> +++ b/xen/include/public/hvm/params.h
>>> @@ -162,21 +162,6 @@
>>>   */
>>>  #define HVM_PARAM_ACPI_IOPORTS_LOCATION 19
>>>
>>> -/* Enable blocking memory events, async or sync (pause vcpu until response)
>>> - * onchangeonly indicates messages only on a change of value */
>>> -#define HVM_PARAM_MEMORY_EVENT_CR0          20
>>> -#define HVM_PARAM_MEMORY_EVENT_CR3          21
>>> -#define HVM_PARAM_MEMORY_EVENT_CR4          22
>>> -#define HVM_PARAM_MEMORY_EVENT_INT3         23
>>> -#define HVM_PARAM_MEMORY_EVENT_SINGLE_STEP  25
>>> -#define HVM_PARAM_MEMORY_EVENT_MSR          30
>>
>> I'm not sure if HVM param slots can be re-used. If they can, leaving a
>> note that the deleted numbers are available for re-sue would be nice.
>> If they can't, leaving a note that they shouldn't be re-used would
>> seem mandatory.
>>
>> Jan
>
> I'm not sure either if they can be reused, I would assume yes so I'll
> make the comment accordingly (unless someone knows more and objects).
>
> All other comments: Ack.
>
> Thanks!
> Tamas

On a second look there seems to be a handful of HVM params that are
already undefined, so they don't seem to get recycled.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel