Re: [Xen-devel] [PATCH 4/4] libxl: More probably detect reentry of destroyed ctx

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH 4/4] libxl: More probably detect reentry of 
destroyed ctx"):
> On Mon, Feb 09, 2015 at 03:51:12PM +0000, Ian Jackson wrote:
> > In libxl_ctx_free:
> > 
> > 1. Move the GC_INIT earlier, so that we can:
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Thanks.

> > +    assert(!ctx->osevent_in_hook);
> > +    CTX->osevent_in_hook += 1000;
> 
> It would be good if you add comment here to say this is used to help
> debugging.

Good idea.  I have done this:

    CTX->osevent_in_hook += 1000; /* make violations easier to debug */

Thanks for your acks.  I will push this to staging now.  I think at
least 1-3 of these, and probably all of them, should be backported.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel