Re: [Xen-devel] [PATCH] tools/ocaml: remove uint32 use added by 674ad2b

[Dave Scott <Dave.Scott@xxxxxxxxxx>]

> On 8 Feb 2015, at 17:11, M A Young <m.a.young@xxxxxxxxxxxx> wrote:
> 
> From 73bab9cb1cb95f35080fadaf1193cbe45327a89c Mon Sep 17 00:00:00 2001
> From: Michael Young <m.a.young@xxxxxxxxxxxx>
> Date: Sun, 8 Feb 2015 15:54:23 +0000
> Subject: [PATCH] tools/ocaml: remove uint32 use added by 674ad2b
> 
> In 674ad2b (xenstore: extend the xenstore ring with a 'closing' signal)
> two uses of uint32 are added to tools/ocaml/libs/xb/xs_ring_stubs.c .
> As of ocaml 4.03.0+dev the uint32 type is no longer supported. This patch
> replaces the uses of uint32 with uint32_t .

Oops, my fault.

This looks good to me â

Acked-by: David Scott <dave.scott@xxxxxxxxxx>

> 
> Signed-off-by: Michael Young <m.a.young@xxxxxxxxxxxx>
> ---
> tools/ocaml/libs/xb/xs_ring_stubs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/ocaml/libs/xb/xs_ring_stubs.c 
> b/tools/ocaml/libs/xb/xs_ring_stubs.c
> index fc9b0c5..fd561a2 100644
> --- a/tools/ocaml/libs/xb/xs_ring_stubs.c
> +++ b/tools/ocaml/libs/xb/xs_ring_stubs.c
> @@ -55,7 +55,7 @@ CAMLprim value ml_interface_read(value ml_interface,
> 
>       cons = *(volatile uint32_t*)&intf->req_cons;
>       prod = *(volatile uint32_t*)&intf->req_prod;
> -     connection = *(volatile uint32*)&intf->connection;
> +     connection = *(volatile uint32_t*)&intf->connection;
> 
>       if (connection != XENSTORE_CONNECTED)
>               caml_raise_constant(*caml_named_value("Xb.Reconnect"));
> @@ -105,7 +105,7 @@ CAMLprim value ml_interface_write(value ml_interface,
> 
>       cons = *(volatile uint32_t*)&intf->rsp_cons;
>       prod = *(volatile uint32_t*)&intf->rsp_prod;
> -     connection = *(volatile uint32*)&intf->connection;
> +     connection = *(volatile uint32_t*)&intf->connection;
> 
>       if (connection != XENSTORE_CONNECTED)
>               caml_raise_constant(*caml_named_value("Xb.Reconnect"));
> -- 
> 2.1.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel