Re: [Xen-devel] [RFC PATCH V3 05/12] xen: Introduce vm_event

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Fri, Feb 6, 2015 at 2:58 PM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 06/02/15 13:54, Tamas K Lengyel wrote:
>>> Please clarify in the patch description whether this (and perhaps
>>> other) copied or cloned code is really just a plain copy with some
>>> renaming, or whether there are any other changes. Reviewing this
>>> as a non-renaming change isn't time well spent in the former case.
>> Ack, this code is identical to mem_event beside the name.
>
> Using git format-patch/diff -M will make this much more obvious by
> creating a diff which looks something like:
>
> --- a/xen/common/mem_event.c
> +++ b/xen/common/vm_event.c
>
> and contains hunks renaming the functions alone.
>
> ~Andrew

I'll take a look at that, it would certainly simplify things.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel