Re: [Xen-devel] [PATCH v2] xen: arm32: reduce default size of the xenheap

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2015-02-05 at 22:01 +0800, Julien Grall wrote:
> If the user requests a xenheap of 0MB, we will use the default size, 
> right? It may be worth to explain this case.

I think it's pretty generally understood that 0 generally means the
default, unless otherwise specified.

> Also with the algorithm to find a range, the Xen heap may be smaller. I 
> would explain that too.

True.

> > +        xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT);
> > +    else
> > +    {
> > +        xenheap_pages = (heap_pages/32 + 0x1fffUL) & ~0x1fffUL;
> > +        xenheap_pages = max(xenheap_pages, 32UL<<(20-PAGE_SHIFT));
> > +        xenheap_pages = min(xenheap_pages, 1UL<<(30-PAGE_SHIFT));
> > +    }
> >       do
> >       {
> 
> You seem to have forgotten to update the condition in the do/while:
> 
> xenheap_pages > 128 << (20 - PAGE_SHIFT);

Seems like I need to refactor this number into a constant somewhere.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel