Re: [Xen-devel] [PATCH OSSTEST v6 9/9] mfi-common, make-flight: create XSM test jobs

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH OSSTEST v6 9/9] mfi-common, make-flight: create XSM 
test jobs"):
> Duplicate Debian PV and HVM test jobs for XSM testing.

This looks pretty good.  I have one minor comment:

> +  xsm_suffix=""
> +  for rv in $@ ; do
> +      case $rv in
> +          enable_xsm=true) xsm_suffix="-xsm";;
> +      esac
> +  done

You could write this as

   case " $* " in
   *" enable_xsm=true "*) xsm_suffix="-xsm";;
   esac

since we don't cope with runvar settings with spaces in anyway.

(If we did you'd have to write   "$@"   not just  $@   .)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel