[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] Fix building error

Jan Beulich writes ("Re: [Xen-devel] [PATCH v2] Fix building error"):
> On 04.02.15 at 16:43, <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> > This is still bad.  What if the user explicitly wants to build without
> > optimisation ?  That's not unusual.  And it's only the combination of
> > -O0 and FORTIFY that fails.  (And it's only on broken platforms that
> > FORTIFY appears by default.)
> Broken platforms? (Of course I ask without having any idea where
> python-config takes that -D_FORTIFY_SOURCE=2 [together with
> everything else it sets] from.)

IMO a platform where the standard Python build tools produce compiler
options incompatible with -O0 is broken.

> Also I think overriding -O<n> here is no worse that Python adding
> -DNDEBUG regardless of us doing a debug build.

What???  I'm just not going there.

> > I guess I would tolerate a patch which spots the combination of
> > _FORTIFY_SOURCE and -O0 and only in that case changes -O1 to -O0.
> But that would have to happen in (I guess) setup.py, unless we want
> to invoke "python-config --cflags" from the Makefile to find out. And
> I don't see myself touching any Python code...

I don't mind some kind of configure check for this particular
brokenness.  python-config --cflags seems like it would be a fine way
to detect it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.