Re: [Xen-devel] [PATCH OSSTEST v5 0/9] XSM test case for OSSTest

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2015-02-03 at 14:10 +0000, Wei Liu wrote:
> On Tue, Feb 03, 2015 at 01:41:45PM +0000, Ian Campbell wrote:
> > On Tue, 2015-02-03 at 13:40 +0000, Ian Jackson wrote:
> > > > Changes in v5 can be found in individual patch.
> > > > 
> > > > See below for output of
> > > >   ./standalone-generate-dump-flight-runvars > origin # master
> > > >   ./standalone-generate-dump-flight-runvars > xsm # this series applied
> > > >   diff -ub ../origin xsm  | grep '-xen-unstable' | sed  's/[ \t]*$//' # 
> > > > nothing
> > > >   diff -ub ../origin xsm  | grep '+xen-unstable' | sed  's/[ \t]*$//'
> > > 
> > > Can you redo this with "| sort" after
> > > ./standalone-generate-dump-flight-runvars ?  That sorts the output by
> > > job which in this case is probably easier to read.
> > 
> > Since you are regenerating can you please also add to your
> > ~/.xen-osstest/config:
> >         PlatformsArmhf midway cubietruck arndale
> > 
> > or some non-empty list at least, so we can see what will happen with
> > platforms defined.
> > 
> > (on production systems this comes from the hostdb).
> > 
> 
> [...]

> +xen-unstable               test-armhf-armhf-xl-arndale                   
> enable_xsm                  false
> +xen-unstable               test-armhf-armhf-xl-cubietruck                
> enable_xsm                  false
> +xen-unstable               test-armhf-armhf-xl                           
> enable_xsm                  false
> +xen-unstable               test-armhf-armhf-xl-midway                    
> enable_xsm                  false

I think this is from after the refactoring we talked about, and it looks
good, thanks.

Arguably it would be better if the enable_xsm was omitted for the
-platform ones, since we just want the default, but that might be a bit
icky in make-flight so I think we can live with it this way.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel