Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2015-02-03 at 12:06 +0000, Wei Liu wrote:
> On Tue, Feb 03, 2015 at 11:22:44AM +0000, Ian Campbell wrote:
> > On Tue, 2015-02-03 at 10:36 +0000, Wei Liu wrote:
> > > Duplicate Debian PV and HVM test jobs for XSM testing.
> > 
> > If ~/.xen-osstest/config contains e.g. "PlatformsArmhf midway cubietruck
> > arndale" (correspodning to the platform-{...} flag being set on some
> > host) then I think this will generate a per platform XSM test, which
> > doesn't seem necessary since XSM isn't platform specific.
> > 
> > So:
> > 
> > > +  for xsm in $test_xsm ; do
> > > +
> > > +    # Basic PV Linux test with xl
> > > +    for platform in '' `getplatforms $xenarch` ; do
> > > +      suffix=${platform:+-$platform}
> > > +      hostflags=${most_hostflags}${platform:+,platform-$platform}
> > > +
> > > +      job_create_test test-$xenarch$kern-$dom0arch-xl$suffix test-debian 
> > > xl \
> > > +                      $xenarch $dom0arch                                 
> > >    \
> > > +                      enable_xsm=$xsm                                    
> > >    \
> > > +                      $debian_runvars all_hostflags=$hostflags
> > > +    done
> > 
> > I think you could pull the for platform loop outside of the for xsm one
> > and remove '' from it, and readd the generic one standalone inside the
> > xsm loop. (You can also simplify the suffix stuff in the platform loop
> > since that is just to handle '' correctly).
> > 
> > Or add "if xsm = true and platform != '' -> continue"? 
> > 
> 
> I use the "continue" trick and now the function looks like:

LGTM. Two nits:

> +      # xsm test is not platform specifc

"specific"

> +      if [ "x$xsm" = "xtrue" -a "x$platform" != "x" ]; then

IIRC Ian previously indicated that he prefers to avoid " when it is
unnecessary, which I think is the case for all 4 words above.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel